Project

General

Profile

Message Carbon and Null Session

Matthew M
Added over 5 years ago

I found occasionally the Tigase server has error logs about a null pointer in MessageCarbons.java around line 100:

        Set<JID> enabledJids = (Set<JID>) session.getCommonSessionData(ENABLED_KEY);

I wonder if this is xmpp session is null (I guess it's because that the client gets disconnected abnormally ? ) while processing this carbons stanza.

Then I realized that MessageCarbons does not override the processNullSessionPacket() method, which I guess is dealing with the null-session case.

And in MessageCarbons::process(), it does not check if session is null either. I wonder if there is any particular reason that MessageCarbons.java

does not deal with null session case?

Thanks!


Replies (1)

Avatar?id=6023&size=32x32

Added by Artur Hefczyc TigaseTeam over 5 years ago

Thank you for the information.

I have added a ticket: #1611 in our system for this. Andrzej will be looking into the problem. This is fairly new addition to our code, hence we are still working and fixing bus.

In the future if you find a bug like this please submit a bug report, this will speed up providing fixes.

    (1-1/1)