Project

General

Profile

Bug #2309

Avatar?id=6023&size=50x50 Avatar?id=6023&size=22x22

Poor privacy-lists performance

Added by Artur Hefczyc TigaseTeam over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
Start date:
2014-09-26
Due date:
2014-10-31
% Done:

100%

Estimated time:
Database:
MySQL
Applicable version:
git/master
Source Code Disclaimer:

Description

There is a forums thread Very low performance about performance problems with Tigase XMPP Server. As it turns out the main bottleneck was privacy-lists plugin. We have run a lot of tests in the past and privacy-lists was never an issue. Please review recent code changes in the plugin to ensure they did not affect performance.

The problem described on a topic is most likely related to their specific use case, that they send messages very soon after user login and a large number of them. So they all hit Tigase when it loads privacy lists from DB after user login. It is likely that once privacy lists are loaded (even if they do not exist) there would be no performance impact afterwards.


Related issues

Related to Tigase XMPP Server - Task #2456: Tigase 5.2.3 releaseClosed2014-11-112014-11-14

Associated revisions

Revision c20d3898 (diff)
Added by Artur Hefczyc TigaseTeam over 4 years ago

Optimized version to avoid calling DB on every packet when there is no privacy lists at all.

History

#1 Avatar?id=6023&size=24x24 Updated by Artur Hefczyc TigaseTeam over 4 years ago

  • Description updated (diff)

#2 Avatar?id=6023&size=24x24 Updated by Artur Hefczyc TigaseTeam over 4 years ago

  • Status changed from New to In QA

I think I fixed the problem but it needs to be verified if it works and if it indeed improves performance. I committed code but forgot to add the ticket number to commit message.

There was a DB call on every single packet if there is no privacy lists. I modified the code so DB is called only once.

#3 Updated by Wojciech Kapcia TigaseTeam about 4 years ago

  • Related to Task #2456: Tigase 5.2.3 release added

#4 Updated by Wojciech Kapcia TigaseTeam about 4 years ago

  • Status changed from In QA to Closed
  • Assignee changed from Wojciech Kapcia to Artur Hefczyc
  • % Done changed from 0 to 100
  • Applicable version changed from git/devel to git/master

Also available in: Atom PDF