Project

General

Profile

Feature #3244

Avatar?id=6023&size=22x22

Option to add components to 'trusted' list

Added by Wojciech Kapcia TigaseTeam over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
2015-06-24
Due date:
2015-07-10
% Done:

0%

Estimated time:
8.00 h
Database:
n/a
Source Code Disclaimer:

Description

Add option that will append list of all/chosen components addresses within cluster to the trusted list, as to avoid manual modification of configuration file, as per:

https://projects.tigase.org/projects/tigase-pubsub/wiki/REST_API

Associated revisions

Revision 48b47197 (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam over 3 years ago

Issue #3244 - modification to add support for trusted list in every component and support for variable in trusted name which will be replaced with cluster names

Revision 1d17d559 (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam over 3 years ago

Issue #3244 - changes required to make this feature work

History

#2 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam over 3 years ago

  • Estimated time set to 8.00 h

#3 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam over 3 years ago

  • Status changed from New to In QA

I implemented support for:

  • setting global list of trusted using --trusted setting

  • setting per component list of trusted using trusted setting in component configuration

In each of this setting as entry which should be trusted it may be passed jid which may include {clusterNode} variable in it, which will force server to add this entry for each of cluster node, ie. if trusted would be set like this:

--trusted=trusted@example.com,http@{clusterNode} 

and we would have 2 cluster nodes test1 and test2 this will be same as setting:

--trusted=trusted@example.com,http@test1,http@test2

If another cluster node will connect then property will be updated for this newly added node.

--trusted is also used to set list of default trusted jids for VHosts, but in this case entries with {clusterNode} will be skipped as this should not be used to set permission on per VHosts basis but on installation or per component basis.

However this change required me to implement ClusteredComponentIfc in BasicComponent as I needed info about every connected/disconnected node on this level. This was needed by the fact that I need to update set of trusted jids when . I updated all existing implementations of ClusteredComponentIfc to call methods from super class to make this work properly.

Now looking at currect implementation of methods nodeConnected and @nodeDisconnected@, I think that in most cases they have very similar implementation in almost every clustered component and similar to current implementation in @BasicComponent@. We could use this and refactor our code so that we would have one implementation of this methods if possible. This is thing to consider.

#4 Updated by Wojciech Kapcia TigaseTeam over 3 years ago

  • Status changed from In QA to Resolved
  • Assignee changed from Wojciech Kapcia to Artur Hefczyc

I've updated PubSub ad-hocs to use changed code and now it works as expected.

Another issue I've encountered - if there's no script then there is no response to the sending entity - I think returning item-not-found in that case -- %kobit , do you agree?

Now looking at currect implementation of methods nodeConnected and @nodeDisconnected@, I think that in most cases they have very similar implementation in almost every clustered component and similar to current implementation in @BasicComponent@. We could use this and refactor our code so that we would have one implementation of this methods if possible. This is thing to consider.

I think this is a good idea - would definitely simplify the implementation.

#5 Updated by Wojciech Kapcia TigaseTeam over 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Artur Hefczyc to Andrzej Wójcik

#6 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam over 3 years ago

  • Status changed from Feedback to In QA
  • Assignee changed from Andrzej Wójcik to Wojciech Kapcia

I fixed issue found during TTS test

#8 Updated by Wojciech Kapcia TigaseTeam over 3 years ago

  • Status changed from In QA to Resolved
  • Assignee changed from Wojciech Kapcia to Artur Hefczyc

#9 Avatar?id=6023&size=24x24 Updated by Artur Hefczyc TigaseTeam over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF