last_login and last_logout are not updated with SASL SCRAM*.
%kobit you mentioned in #4878#note-1 that those are/may be needed using external tools so should this be fixed?
#1 Updated by Artur Hefczyc almost 2 years ago
- Assignee changed from Artur Hefczyc to Wojciech Kapcia
Yes, this should be fixed.
I wonder why this problem exists at all. There is/was an API in Tigase and these columns are updated automatically without any special code in the plugin. So it should work for all authentication methods. Does it not use/follow our APIs the way other plugins do?
#6 Updated by Artur Hefczyc almost 2 years ago
- Assignee changed from Artur Hefczyc to Bartosz Małkowski
I understand, in the past not all authentication methods used stored procedures either, at least not for authentication. But they all recorded user login/logout time. I guess we lost this functionality at some point. Is the user login/logout time recorded for any other methods/mechanisms? What about SASL external?
It seems to me that it is relatively simple thing to implement and maintain but very useful so we should make sure we have it back for all authentication methods and mechanisms.
Therefore it should be implemented through some common API, in such a way that it is called automatically, even if somebody implements a new mechanism in the future. Also, make sure it is configurable, and can be switched off.
#7 Updated by Bartosz Małkowski almost 2 years ago
- Status changed from New to In QA
- Assignee changed from Bartosz Małkowski to Artur Hefczyc
I'm changing current API (*Repo) to add methods to store login time in databases. It will be called by SaslAuth, so it will works the same way for all SASL mechanisms.
#11 Updated by Wojciech Kapcia almost 2 years ago
self-notes: new schema files added (*-7-2-sp.sql):
code responsible for checking version should be updated;
db-properties should be updated (creating *-7-2.sql and properties files);
including upgrade script/handling.
Not sure if #1092 will be included in 7.2.0 (as we should make it ready for release for spring-ish time frame)