Project

General

Profile

Task #5088

Avatar?id=6023&size=50x50 Avatar?id=6023&size=22x22

SaslAuth code review

Added by Artur Hefczyc TigaseTeam almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
2017-03-16
Due date:
2017-03-31
% Done:

0%

Estimated time:
Database:
n/a

Description

While looking at the SaslAuth plugin I noticed some inconsistencies in the code. I am not sure if I understand it correctly, please review the code and fix if necessary:

process(...) method.

There is a condition: if(session.isAuthorized()) {…} which if true, logs the user out and closes stream and TCP/IP connection but then there is no if-else statement or return from the method and it continues to process SASL requests. This seems like incorrect. The stream and connection would be closed anyway but processing SASL request in such a case is a waste of resources.

Associated revisions

Revision 9590ac48 (diff)
Added by Bartosz Małkowski TigaseTeam almost 2 years ago

#5088: SaslAuth code review

fix: unnecessary request processing after closing session

History

#1 Avatar?id=6098&size=24x24 Updated by Bartosz Małkowski TigaseTeam almost 2 years ago

  • Status changed from New to Resolved
  • Assignee changed from Bartosz Małkowski to Artur Hefczyc

You're right!

I missed it.

#2 Avatar?id=6023&size=24x24 Updated by Artur Hefczyc TigaseTeam almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF