Project

General

Profile

Bug #5415

Setup runs into issues with two types of message archive

Added by Daniel Wisnewski IoT 1 Cloud almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
Due date:
2017-05-03
% Done:

100%

Estimated time:
Database:
n/a
Applicable version:
git/master
Source Code Disclaimer:

Description

Setup module shows two different checkboxes for Message Archive XEP-0146 but does not show one for MAM XEP-0313.

If the first option is selected, MA is not mentioned in init.properties (I guess since this is enabled by default).

Selecting the second option, and not the first, errors arise with MA not being active (perhaps a null option?)

}
'message-archive' (active: false) {}
'sess-man' () {
    'message-archive-xep-0136' (active: false) {}
    'urn:xmpp:mam:1' (active: false) {}
}

Interestingly selecting both results in MA being turned on, but no configuration set in Sess-man.

'sess-man' () {}
'unified-archive' () {}

I am wondering if it would be a good idea to ask the user for either/or for 146 and 313 as it seems possible to turn both on and may be confusing to people who do not realize our MA can serve both at the same time.

Associated revisions

Revision 02a02d5c (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam almost 2 years ago

#5415: updated component description

Revision 01d247da (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam almost 2 years ago

#5415: modified setup to properly configure UA component

History

#1 Updated by Daniel Wisnewski IoT 1 Cloud almost 2 years ago

Daniel Wisnewski wrote:

...but does not show one for MAM XEP-0313.

I see that plugins has MA-0313 on page 2, I forgot to change this before I posted ticket.

#2 Updated by Wojciech Kapcia TigaseTeam almost 2 years ago

  • Due date set to 2017-05-03
  • Assignee changed from Wojciech Kapcia to Andrzej Wójcik

Thanks Dan for reporting this.

Andrzej, as we discussed in chat:

  • Options in the setup must be corrected;

  • ideally UA should be a sub-option to MA (and selecting UA checks MA and makes it inactive) [I know that it's possible to have fancy setup with UA and MA using separate DB but we are covering here only setup and this has to be comprehensible to user running setup].

Actual logic of resulting configuration is correct.

#3 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam almost 2 years ago

  • Status changed from New to In QA
  • Assignee changed from Andrzej Wójcik to Wojciech Kapcia

I've added logic to warn a user when both components are enabled and changed processors selection logic to properly behave when UA is selected instead of MA.

#4 Updated by Wojciech Kapcia TigaseTeam almost 2 years ago

  • Status changed from In QA to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF