Project

General

Profile

Bug #5429

DynamicRoster doesn't seem to work

Added by Wojciech Kapcia TigaseTeam almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
Due date:
2017-05-03
% Done:

100%

Estimated time:
Database:
n/a
Applicable version:
git/master
Source Code Disclaimer:

Description

'sess-man' {
    'dynamic-roster-classes' = 'tigase.xmpp.impl.roster.DynamicRosterTest'
}

Relevant option from 7.1.0:

sess-man/plugins-conf/dynamic-roster-classes=tigase.xmpp.impl.roster.DynamicRosterTest

Associated revisions

Revision 07e24d05 (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam almost 2 years ago

#5429: conversion of DynamicRoster support to kernel

Revision 4b8c0ed4 (diff)
Added by W Administrator almost 2 years ago

#4874: update common properties with dynamic-roster-fix (#5429)

Revision c77b5839 (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam almost 2 years ago

#5429: fixed issue with singleton instance field not being set

History

#1 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam almost 2 years ago

  • Status changed from New to In QA
  • Assignee changed from Andrzej Wójcik to Wojciech Kapcia

I adjusted implementation to work with Tigase Kernel and updated configuration converter.

Now it should be used in following way:

'sess-man' {
    'dynamic-rosters' () {
        DynamicRosterTest (class: tigase.xmpp.impl.roster.DynamicRosterTest) {}
        DynamicRosterTest123 (class: tigase.xmpp.impl.roster.DynamicRosterTest123) {}
    }
}

so that now we have dynamic-roster bean (instance of tigase.xmpp.impl.roster.DynamicRoster@) for which you register new beans which implements @DynamicRosterIfc

#2 Updated by Wojciech Kapcia TigaseTeam almost 2 years ago

  • Status changed from In QA to Feedback
  • Assignee changed from Wojciech Kapcia to Andrzej Wójcik

Andrzej Wójcik wrote:

I adjusted implementation to work with Tigase Kernel and updated configuration converter.

Now it should be used in following way:

[...]

so that now we have dynamic-roster bean (instance of tigase.xmpp.impl.roster.DynamicRoster@) for which you register new beans which implements @DynamicRosterIfc

I've tested above config and dynamic roster elements are not included.

instance in tigase.xmpp.impl.roster.DynamicRoster#getDynamicRosters is still @null@.

#3 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam almost 2 years ago

  • Due date set to 2017-05-03
  • Status changed from Feedback to In QA
  • Assignee changed from Andrzej Wójcik to Wojciech Kapcia

You are right, I forgot to set instance to this within bean initialization method. Took me a while to understand that this part was missing.

#4 Updated by Wojciech Kapcia TigaseTeam almost 2 years ago

  • Status changed from In QA to Closed
  • % Done changed from 0 to 100

Works:

Dynamic Roster 1 (c2s)  success     0 sec   1   57 ms   Dynamic roster storage test     Dynamic Roster 1 (c2s)
Dynamic Roster 2 (c2s)  success     0 sec   1   170 ms  Dynamic roster merge test   Dynamic Roster 2 (c2s)

Also available in: Atom PDF