Project

General

Profile

Bug #6842

DefaultTypesConverter is case-sensitive with enums

Added by Wojciech Kapcia TigaseTeam about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Database:
n/a
Applicable version:
git/master
Source Code Disclaimer:

Description

Not sure if this is bug per se but currently DefaultTypesConverter is case-sensitive with enums, which obviously causes issues when configuration is not strict with it (or was converted from previous version) which may cause errors during startup.

The proposal is to make it case-insensitive (as the enums cases are currently all over the place) as alternatively adjusting documentation (eg.: http://docs.tigase.org/tigase-server/snapshot/Administration_Guide/html_chunk/watchdog.html) and converter would be… tedious without much benefit.

%kobit %andrzej.wojcik ( %bmalkow ?)


Related issues

Related to Tigase XMPP Server - Feature #6834: Improve DomainFilter configuration in VHostItemClosed

Associated revisions

Revision 92564c5a (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam about 1 year ago

#6842: added case-insensitive lookup for enum values to DefaultTypesConverter

Revision f033b865 (diff)
Added by Daniel Wisnewski IoT 1 Cloud about 1 year ago

#6842 Update enum capatalization in watchdog documentation

History

#1 Updated by Wojciech Kapcia TigaseTeam about 1 year ago

  • Related to Feature #6834: Improve DomainFilter configuration in VHostItem added

#2 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam about 1 year ago

  • Status changed from New to In Progress

#3 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam about 1 year ago

  • Status changed from In Progress to In QA
  • Assignee changed from Andrzej Wójcik to Wojciech Kapcia
  • % Done changed from 0 to 100

I'm generally against allowing usage of values with different letter cases, but in this case, I agree that we should allow this - at least for compatibility reasons. However, I would still want to clean up documentation and use proper values without a need for case-insensitive lookup of enum values.

#4 Updated by Wojciech Kapcia TigaseTeam about 1 year ago

  • Assignee changed from Wojciech Kapcia to Daniel Wisnewski

Andrzej Wójcik wrote:

I'm generally against allowing usage of values with different letter cases,

Totally agree

but in this case, I agree that we should allow this - at least for compatibility reasons. However, I would still want to clean up documentation and use proper values without a need for case-insensitive lookup of enum values.

Daniel - do you think you will be able to update documentation (case of some options)?

#5 Updated by Daniel Wisnewski IoT 1 Cloud about 1 year ago

  • Status changed from In QA to Feedback
  • Assignee changed from Daniel Wisnewski to Wojciech Kapcia

After a thorough check of all enums in code from a grep search, I have not found any more instances of enums that are not in line with documentation and code.

#6 Updated by Wojciech Kapcia TigaseTeam about 1 year ago

  • Status changed from Feedback to Closed

Thank you.

Also available in: Atom PDF