Project

General

Profile

Bug #7443

MUC accepts joining room with incorrect value for since attribute in history element

Added by Andrzej Wójcik IoT 1 CloudTigaseTeam 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Start date:
Due date:
% Done:

100%

Estimated time:
Source Code Disclaimer:

Description

MUC accepts joining a room with incorrect value for since attribute in history element. In this case, it assumes that since attribute was not set and creates confusion. If the value for the attribute is incorrect (not parsable), the component should respond with bad-request error.


Related issues

Related to Tigase MUC - Bug #8093: Cannot join to room with SwiftIn QA

Associated revisions

Revision 5c8b3955 (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam 10 months ago

#7443: added support for legacy delay timestamp formatting to TimestampHelper

Revision e774a1e7 (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam 10 months ago

#7443: added validation of presence/x/history element attributes and disabled by default sending timestamps in XEP-0091

Revision 6658ee11 (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam 10 months ago

#7443: added test case to verify timestamps handling by MUC

Revision 76ab7f74 (diff)
Added by Andrzej Wójcik IoT 1 CloudTigaseTeam 10 months ago

#7443: added information on how to enable XEP-0091

History

#1 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam 10 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

I've added validation for all history attributes and code sending proper errors.
I've disabled by default sending timestamp in the message in legacy delay format - XEP-0091. (this can be enabled).
I've added a test case to confirm that verification of history attributes works properly.

I still need to add information to documentation about to how to enable legacy delay timestamps.

#2 Updated by Andrzej Wójcik IoT 1 CloudTigaseTeam 10 months ago

  • Status changed from In Progress to In QA
  • Assignee changed from Andrzej Wójcik to Wojciech Kapcia
  • % Done changed from 90 to 100

Documentation added.

#3 Updated by Wojciech Kapcia TigaseTeam 10 months ago

  • Status changed from In QA to Closed

#4 Avatar?id=6098&size=24x24 Updated by Bartosz Małkowski TigaseTeam 6 months ago

  • Related to Bug #5806: Crash on device orientation change in account properties added

#5 Avatar?id=6098&size=24x24 Updated by Bartosz Małkowski TigaseTeam 6 months ago

  • Related to deleted (Bug #5806: Crash on device orientation change in account properties)

#6 Avatar?id=6098&size=24x24 Updated by Bartosz Małkowski TigaseTeam 6 months ago

  • Related to Bug #8093: Cannot join to room with Swift added

Also available in: Atom PDF